Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo deselecting textures #4

Open
edsilv opened this issue Jun 14, 2013 · 6 comments
Open

Undo deselecting textures #4

edsilv opened this issue Jun 14, 2013 · 6 comments
Labels

Comments

@edsilv
Copy link

edsilv commented Jun 14, 2013

In HH, select the plane, change its texture to anything except <no selection>, change back to <no selection>, original plane doesn't come back.

@edsilv
Copy link
Author

edsilv commented Jun 14, 2013

BTW this is in the Image Skin part of the properties panel.

I think it's a problem because these properties should be disabled. If you try changing rotation or x or y they snap back to their original values, whereas the drop down boxes can be changed.

I think the drop downs should have a disabled state where they can't be changed. Also dragging the rotation slider just for it to snap back is weird.

I think to denote that these properties are out of scope we should do something like darken the labels or something and make the fields completely un-editable.

Or, maybe we shouldn't be showing properties that can't be edited at all...

@robsilv
Copy link
Member

robsilv commented Jun 14, 2013

The plane is getting it's skin from the TextureAtlas. TextureAtlas and Texture are mutually exclusive values, so selecting a Texture will clear the TextureAtlas. Deselecting the Texture doesn't automatically repopulate the TextureAtlas, as we can't assume this is what the user wants to do.

@robsilv
Copy link
Member

robsilv commented Jun 14, 2013

It's fine to change the Texture properties on the ImageSkin, it's just the Transform properties of the Skin that are being overridden by the Transform2D sibling.

@edsilv
Copy link
Author

edsilv commented Jun 14, 2013

So the clearing of the TextureAtlas isn't recorded as an operation? Otherwise, undoing would undo the clear right?

@robsilv
Copy link
Member

robsilv commented Jun 14, 2013

Ah, you didn't mention undo before. So this is a problem you're experiencing with undo then, rather than changing something, then changing it back in the Properties Inspector?

@edsilv
Copy link
Author

edsilv commented Jun 14, 2013

Well, I didn't know about the mutual exclusivity of those properties. So I didn't understand why the plane was disappearing. I guess it makes sense, but the fact you can't undo to get the plane back isn't right, surely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants