Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Control #8

Open
mikeholler opened this issue Jan 18, 2014 · 5 comments
Open

Access Control #8

mikeholler opened this issue Jan 18, 2014 · 5 comments
Assignees
Milestone

Comments

@mikeholler
Copy link

Make sure users can only view/edit things that they have permissions for.

@ghost ghost assigned wwforg Jan 18, 2014
@mikeholler mikeholler modified the milestone: v1.0 Feb 7, 2014
@ZAM-
Copy link
Contributor

ZAM- commented Mar 14, 2014

Is this going to be solved by the route filters?

@wwforg
Copy link
Member

wwforg commented Mar 14, 2014

Yes. I have not currently looked over the filters as much as I'd like at the moment, I've been preparing for a final today. Once that is over with though I'll be able to refocus on the authorization side of things

@mboie
Copy link

mboie commented Mar 14, 2014

@wwforg Have you added the functionality for logging out of the app? I assume we need to remove the user's authorization from the session somehow. I only ask because I was just looking over your code from the last pull request and didn't see anything related to this. And both the projects page and editor page have logout buttons that call for such action.

Regardless, I am only double-checking because I don't remember this being mentioned recently and noticed that it hadn't been done on the official version. It is quite possible that it is already set up on your version and just not in this one yet... but I figured I would ask just in case it had been forgotten.

I have to go out for a few hours but if you do need any information on where those buttons are located on their respective pages, @kwpembrook can point them out.

@wwforg
Copy link
Member

wwforg commented Mar 14, 2014

I have not added that yet, let me know where those buttons are and I will work on it. It should be as simple as adding a route so when they click the logout button, it calls a function in my controller that clears out and ends the session, then deletes the login object, and finally redirect back to the main login page. Definately not forgotten, just not implemented yet. Thanks for checking!

@mboie
Copy link

mboie commented Mar 14, 2014

Sounds good. I was thinking you might be able to do something along those lines.

The button for the editor page is on line 51 of the editor.blade.php file for the organization.
The button for the projects page is on line 41 of the ProjectsPage.blade.php file for the organization.

If for whatever reason your line numbers are different, just do control-f "logout" and it should take you straight to it.

mikeholler pushed a commit that referenced this issue Mar 16, 2014
removed redundant route to cmd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants