Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index-out-of-bounds error when retrieving cards from BasicShuffle with a deck of length 1 #27

Closed
JasonW029 opened this issue Dec 1, 2021 · 0 comments · Fixed by #36
Closed

Index-out-of-bounds error when retrieving cards from BasicShuffle with a deck of length 1 #27

JasonW029 opened this issue Dec 1, 2021 · 0 comments · Fixed by #36
Labels
bug Something isn't working

Comments

@JasonW029
Copy link
Contributor

When retrieving a card from a BasicShuffle, if it was built on a deck of exactly length 1, then it throws an index out of bounds exception after trying to retrieve two cards.

I believe this can be fixed by changing the card shuffling algorithm to accommodate for such situations.
@SirRAL SirRAL added the bug Something isn't working label Dec 2, 2021
@SirRAL SirRAL mentioned this issue Dec 4, 2021
Merged
@SirRAL SirRAL closed this as completed in #36 Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix BasicShuffler index out of bounds exception CSC207-UofT/course-project-024
2 participants
@SirRAL @JasonW029