Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile uses different versions for build and binary #66

Open
Rahulbeniwal26119 opened this issue Dec 29, 2024 · 3 comments
Open

Dockerfile uses different versions for build and binary #66

Rahulbeniwal26119 opened this issue Dec 29, 2024 · 3 comments

Comments

@Rahulbeniwal26119
Copy link
Contributor

I noticed that Dockerfile uses different Go versions for the build and binary stages:

Stage 1 - build stage

######################################
FROM golang:1.23.3 as builder

Stage 2 - Binary stage

######################################
FROM golang:1.21.13

Can anyone please share some insights on whether this is an intended change? As per my understanding, we should keep the same version for both.

Thanks.

@Abhishekvrshny
Copy link
Collaborator

Thanks for raising the issue @Rahulbeniwal26119 . propeller expects go 1.23 and that's the right version to use. The build stage uses the right golang image. For the binary execution stage, a golang image is not necessarily required. The binary built could very well run with a vanilla alpine image. Would you like to fix that?

@Rahulbeniwal26119
Copy link
Contributor Author

Yes, I Will raise a fix today

@Rahulbeniwal26119
Copy link
Contributor Author

Hi @Abhishekvrshny I raised a PR
https://github.com/CRED-CLUB/propeller/pull/67/files

I also fixed the warning too while making images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants