Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support_years field is badly named #2

Open
haarg opened this issue Jan 8, 2025 · 2 comments
Open

support_years field is badly named #2

haarg opened this issue Jan 8, 2025 · 2 comments
Assignees
@timlegge

Comments

@haarg
Copy link

haarg commented Jan 8, 2025

The support_years field is the number of years of Perl releases that are supported with security fixes. This isn't obvious from the name of the field. I think it would be better as something like perl_support_years.

The current documentation for the support_years method also states:

Get the number of years of support to be expected

This does not match the documentation of the attribute or the way the data is used.
@timlegge
Copy link
Contributor

timlegge commented Jan 8, 2025

I will try to fix later today.

@timlegge timlegge self-assigned this Jan 8, 2025
timlegge added a commit that referenced this issue Jan 8, 2025
@timlegge
Fixes #2 Use perl_support_years instead of support_years
a6cc4a8
@timlegge
Copy link
Contributor

timlegge commented Jan 8, 2025

@haarg if you don't mind taking a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timlegge timlegge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haarg @timlegge