Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor upwind advection tracer arrays #542

Open
apcraig opened this issue Dec 11, 2020 · 0 comments
Open

Refactor upwind advection tracer arrays #542

apcraig opened this issue Dec 11, 2020 · 0 comments

Comments

@apcraig
Copy link
Contributor

apcraig commented Dec 11, 2020

This is a follow up from #535. When upwind advection was un-deprecated, some questions were raised about the correctness of the implementation, particularly whether all the proper arrays were being advected as a result of the state_to_work and work_to_state implementation. Ultimately, the same arrays should be advected as in the remap, and we are confident that remap is doing it correctly. The problem is that the creation of the advection arrays for remap is partly inside remap and partly in state_to_tracers and tracers_to_state.

The state_to_work and work_to_state implementation needs to be reviewed carefully and possibly updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant