You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow up from #535. When upwind advection was un-deprecated, some questions were raised about the correctness of the implementation, particularly whether all the proper arrays were being advected as a result of the state_to_work and work_to_state implementation. Ultimately, the same arrays should be advected as in the remap, and we are confident that remap is doing it correctly. The problem is that the creation of the advection arrays for remap is partly inside remap and partly in state_to_tracers and tracers_to_state.
The state_to_work and work_to_state implementation needs to be reviewed carefully and possibly updated.
The text was updated successfully, but these errors were encountered:
This is a follow up from #535. When upwind advection was un-deprecated, some questions were raised about the correctness of the implementation, particularly whether all the proper arrays were being advected as a result of the state_to_work and work_to_state implementation. Ultimately, the same arrays should be advected as in the remap, and we are confident that remap is doing it correctly. The problem is that the creation of the advection arrays for remap is partly inside remap and partly in state_to_tracers and tracers_to_state.
The state_to_work and work_to_state implementation needs to be reviewed carefully and possibly updated.
The text was updated successfully, but these errors were encountered: