Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater does not show option to choose version/branch #82

Closed
agajdosi opened this issue Sep 13, 2022 · 5 comments
Closed

Updater does not show option to choose version/branch #82

agajdosi opened this issue Sep 13, 2022 · 5 comments

Comments

@agajdosi
Copy link

So, for some reason the updater does not show me option to choose version or branch. It does sometimes but most of the time it just installs the last version without ability to choose.

@TheDuckCow
Copy link
Collaborator

Hey @agajdosi apologies for the delayed reply, can you share your repo where you have this configured? Will be easiest to look at specific; you could also just pasted in the section of your def register function in the ops file, as that has most of the config.

@agajdosi
Copy link
Author

Hi @TheDuckCow, thank you for the reply. Here is the file: https://github.com/BlenderKit/blenderkit/blob/master/addon_updater_ops.py I have tried to track it down, but I could not really find the problematic change. Thanks for taking a look!

@TheDuckCow
Copy link
Collaborator

Hi @agajdosi I believe this would be the issue, set this line to True and this line needs to list the branches if you want to show anything other than tags.

However I tried your latest build, there is something else funny about your operator bpy.ops.mcprep.updater_update_target() as it isn't invoking the popup to select between versions (ie this button should create a popup to select different versions, but for me it's just immediately jumping to install... I don't know what version).

Screen Shot 2022-10-30 at 11 41 07 AM

Are you aware of any custom modification of the module? Looks like the draw code is specifically forcing users to install:

bpy.ops.blenderkit.updater_update_target(target='BlenderKit 3.3.0.221027', clean_install=False)

You should get a popup like this (reference: the MCprep addon); while this repo doesn't have the option to include branches, this is where they would show up if enabled:
Screen Shot 2022-10-30 at 11 44 03 AM

@TheDuckCow
Copy link
Collaborator

Closing this issue as it has bene awhile, but let me know if still an open issue.

@agajdosi
Copy link
Author

@TheDuckCow Sorry for the delay, missed the emails. The issue dissapeared, seems good right now, will let you know if it fails again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants