Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] None steam game detection/manual adding #10

Closed
SaltySamurai opened this issue Jan 24, 2024 · 9 comments
Closed

[Feature Request] None steam game detection/manual adding #10

SaltySamurai opened this issue Jan 24, 2024 · 9 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SaltySamurai
Copy link

I have some games added for emulation, at the moment I just keep them all on the same card so I know where they all are, but it would be nice to be able to use the sorting features in Tab Master to see games installed on the SD card even if it's an emulated title or other none steam games that does not show up as installed.

@CEbbinghaus
Copy link
Owner

Assuming you already have the latest version of MicroSDeck installed it should theoretically just work. Tab-Master just asks MicroSDeck for the games that are on the card and should display them in the list. I have been able to show non steam games as long as they were added to MicroSDeck

@CEbbinghaus CEbbinghaus linked a pull request Feb 12, 2024 that will close this issue
2 tasks
@jfreuden
Copy link
Contributor

I was able to reproduce this. @CEbbinghaus can you modify this to a bug, and I'll work it?
I think I have a reliable way to trigger it, as well as maybe a way to workaround it such that the Non-Steam games stick around

@CEbbinghaus CEbbinghaus added the bug Something isn't working label Feb 12, 2024
@CEbbinghaus
Copy link
Owner

That would be awesome if you are able to reproduce it I would be eternally grateful if you posted the steps to reproduce the problems too so I can try make it happen locally too

@jfreuden
Copy link
Contributor

Narrowing in on it, will post shortly. Right now it deletes all user-facing mappings almost every time I enter desktop mode and open Steam. The entry remains in the datastore, but the mapping seems invalid. When I get a cleaner repro list, I'll post here

@jfreuden
Copy link
Contributor

I can't seem to figure out what last variable was triggering it 😢 . Merely going into desktop mode is not generally enough to cause the disassociation. While trying to hone in, I changed something and can't get it to pop anymore. I'll look at it more later this week unless someone else can beat me to a reliable repro.

@CEbbinghaus
Copy link
Owner

That is an amazing start. No wonder I could never repro it. I just SSH into my steamdeck so I never enter desktop mode. I will need to check with Nabel0 to see if this is what is happening to them.

@jfreuden
Copy link
Contributor

I saved my datastore after it vanished again (so it had the stale info), and then resaved the store after I re-added it (so same data, but updated linking.
Comparing with diff -c <(jq -S . fileInStoreNotLinked.json) <(jq -S . fileInStoreIsLinked.json) yields the following diff

***************
*** 3,9 ****
      "275048534431544260da201139017400": 4539974638454541300,
      "275048534432353660da63ea78017700": 6083790000313430000,
      "275048534432353660da63f9b2017700": 13718731425900145000,
!     "6f001353442020201000000894014c00": 8596948639491825000,
      "6f0013534420202010000009b9014c00": 7821745755656968000,
      "9f54493132384742003321718b017a00": 3521314557363902000
    },
--- 3,9 ----
      "275048534431544260da201139017400": 4539974638454541300,
      "275048534432353660da63ea78017700": 6083790000313430000,
      "275048534432353660da63f9b2017700": 13718731425900145000,
!     "6f001353442020201000000894014c00": 14469494551128812000,
      "6f0013534420202010000009b9014c00": 7821745755656968000,
      "9f54493132384742003321718b017a00": 3521314557363902000
    },
***************
*** 1804,1809 ****
--- 1804,1813 ----
              "version": 1
            },
            {
+             "idx": 28,
+             "version": 1
+           },
+           {
              "idx": 6,
              "version": 1
            },
***************
*** 2347,2353 ****
              "uid": "3677325494"
            }
          },
!         "links": []
        },
        "version": 1
      },
--- 2351,2362 ----
              "uid": "3677325494"
            }
          },
!         "links": [
!           {
!             "idx": 1,
!             "version": 1
!           }
!         ]
        },
        "version": 1
      },

I don't make heads or tails of it yet other than some id's are changing. I'm going to delete TabMaster, wipe my datastore and get the same sort of data with a cleaner set of cards next time it repros

@CEbbinghaus
Copy link
Owner

Hmmm, that looks fairly standard, a link between a game and a card got changed (the last 2) and the hash of one of the cards changed (which also checks out). None of this is out of the ordinary

@CEbbinghaus CEbbinghaus added this to the 1.0.0 milestone Feb 16, 2024
@CEbbinghaus CEbbinghaus added enhancement New feature or request bug Something isn't working and removed bug Something isn't working enhancement New feature or request labels Feb 16, 2024
@CEbbinghaus CEbbinghaus self-assigned this Feb 16, 2024
@jfreuden
Copy link
Contributor

This should have been fixed by @CEbbinghaus in this commit from #14 . It should be on master / nightly builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants