Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance var @ssm_skip_resolution only settable as ENV var #10

Open
ashleygould opened this issue Feb 14, 2021 · 0 comments
Open

Instance var @ssm_skip_resolution only settable as ENV var #10

ashleygould opened this issue Feb 14, 2021 · 0 comments

Comments

@ashleygould
Copy link
Contributor

Currently a user can set ENV['SSM_SKIP_RESOLUTION']. This will disable setting the @client in Uc3Ssm::ConfigResolver instances. But the user can not directly set a ssm_skip_resolution option when calling Uc3Ssm::ConfigResolver.new().

Also, this instance var should be treated strictly as boolean. Just checking if ENV.key?('SSM_SKIP_RESOLUTION') is not sufficient. The user should be able to set ENV['SSM_SKIP_RESOLUTION'] = 'false'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant