Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Decreasing minimum cluster size doesn't cause nodes/cluster to reappear as expected #889

Open
dacowan404 opened this issue Jan 3, 2025 · 1 comment
Assignees

Comments

@dacowan404
Copy link
Collaborator

Increasing minimum cluster size causes nodes/clusters to disappear as expected but decreasing doesn't cause them to reappear as expected. Instead, minimum cluster size must be set to 1 to get them to reappear.
Under the hood, it looks like when a cluster is hidden through minimum cluster size, the cluster is split such that each of those nodes is now a singleton (1 node cluster). Therefore, by setting minimum cluster size back to 1 the singletons reappear and are joined back together in the cluster. This splitting shouldn't occur and is the reason for the bug.

@dacowan404 dacowan404 self-assigned this Jan 3, 2025
@dacowan404 dacowan404 changed the title Decreasing minimum cluster size doesn't cause nodes/cluster to reappear as expected Angular: Decreasing minimum cluster size doesn't cause nodes/cluster to reappear as expected Jan 3, 2025
dacowan404 added a commit to mossy426/MicrobeTrace that referenced this issue Jan 6, 2025
…ze) and CDCgov#891 (bug related to 2D Node labels disappearing);
@dacowan404
Copy link
Collaborator Author

dacowan404 commented Jan 6, 2025

removed code that called tagClusters function when minimum cluster size was updated. This function led to the splitting of cluster that were less than minimum. deployed to mossy url 1/6/25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant