Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psuade-Lite Requirement #1142

Closed
boverhof opened this issue May 9, 2023 · 7 comments · Fixed by #1226
Closed

Psuade-Lite Requirement #1142

boverhof opened this issue May 9, 2023 · 7 comments · Fixed by #1226
Assignees
Labels
FOQUS GUI Issues related to information displayed on the GUI, or broken buttons Priority:High High Priority Issue or PR PSUADE Issues that involve the PSUADE plugin

Comments

@boverhof
Copy link
Member

boverhof commented May 9, 2023

UQ and OUU require psuade-lite

  • Need to tighten up how at least the User is informed
  • UQ and OUU maybe shouldn't be selectable if psuade-lite is not found
  • default psuade location is bogus if psuade is not installed
  • in many scenarios this behavior causes UQ Run to hang

Reference

@boverhof boverhof added the FOQUS GUI Issues related to information displayed on the GUI, or broken buttons label May 9, 2023
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label May 9, 2023
@boverhof
Copy link
Member Author

boverhof commented May 9, 2023

psuade lite location specified in two places

$ find . -name \*.py  | xargs grep -s 'psuade_project'
./foqus_lib/framework/uq/LocalExecutionModule.py:                "C:/Program Files (x86)/psuade_project %s/bin/psuade.exe"
./foqus_lib/framework/session/session.py:            or "C:/Program Files (x86)/psuade_project 1.7.5/bin/psuade.exe"

mainWindows hook

  • maybe just check for OUU dependencies here, and if not found throw an alert
(py3.9) Joshuas-MacBook-Pro:foqus-boverhof boverhof$ sed -n '840,846p' foqus_lib/gui/main/mainWindow.py 
    def showOuuSetup(self):
        """
        Show the OUU screen
        """
        self.changeScreen()
        self.mainWidget.setCurrentIndex(self.screenIndex["ouu"])


@lbianchi-lbl
Copy link
Contributor

#1085 would indirectly address the issue of the PSUADE requirement: under the proposed design, the applications that need PSUADE (OUU, UQ, etc) would be able to explicitly check for PSUADE without preventing the rest of the FOQUS GUI from being loaded.

@ksbeattie
Copy link
Member

See #1153 for an examples of this and a possible solution/improvement.

@sotorrio1 sotorrio1 added the PSUADE Issues that involve the PSUADE plugin label Dec 5, 2023
@ksbeattie
Copy link
Member

@sotorrio1 will take a look into this

@lbianchi-lbl
Copy link
Contributor

  • On the opposite end of the spectrum from Initial draft for experimental plugin implementation #1153 (i.e. a general solution requiring considerable effort that would address this issue indirectly), we could try to resolve the specific problem of the PSUADE dependency by making it a hard requirement for FOQUS, i.e. FOQUS won't be able to start if PSUADE is not found
  • This would allow us to simplify (i.e. get rid of) a lot of the stateful logic of using the user-editable FOQUS settings to specify the PSUADE path (which made sense when PSUADE needed to be installed manually, but is not really needed now that psuade-lite is available via Conda
  • The only real cons I can personally think of would be:
    • Losing the ability of using the parts of FOQUS that don't require PSUADE
    • Not being able to start FOQUS, realize that PSUADE is missing, installing PSUADE and resume the FOQUS workflow without having to restart the FOQUS application
  • In summary, I think the tradeoff would be worth it and we'd resolve this issue with a much smaller effort compared to Initial draft for experimental plugin implementation #1153 or other approaches requiring developing new code

@ksbeattie
Copy link
Member

@boverhof will take alook at @lbianchi-lbl solution of removing the run-time checks for psuade in preference to a single check at start-up. This way if psuade is not installed FOQUS exists with a message about needing psuade installed.

@lbianchi-lbl
Copy link
Contributor

I can take a stab at this and open a draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FOQUS GUI Issues related to information displayed on the GUI, or broken buttons Priority:High High Priority Issue or PR PSUADE Issues that involve the PSUADE plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants