feat: theme system #5619
feat: theme system #5619
Conversation
|
please explain in more detail what the "theme system" is, it already exists, doesn't it? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/kotlin/net/ccbluex/liquidbounce/integration/theme/ThemeManager.kt
Fixed
Show fixed
Hide fixed
| value = mutableListOf( | ||
| *theme.components | ||
| .filter { factory -> factory.default } | ||
| .map { factory -> factory.new(theme) }.toTypedArray() | ||
| ) |
Check warning
Code scanning / detekt
In most cases using a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty. Warning
| } | ||
|
|
||
| val matStack = MatrixStack() | ||
| override fun render(context: DrawContext, delta: Float) { |
Check warning
Code scanning / detekt
One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand. Warning
.../net/ccbluex/liquidbounce/integration/theme/themes/liquidbounce/routes/EmptyDrawableRoute.kt
Fixed
Show fixed
Hide fixed
| * | ||
| * @param jsonObject JsonObject | ||
| */ | ||
| private fun configureConfigurable(configurable: Configurable, jsonObject: JsonObject) { |
Check warning
Code scanning / detekt
One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand. Warning
| return@onChange enabled | ||
| } | ||
| val inbuiltThemes = arrayOf(LiquidBounceTheme) | ||
| var themes = mutableListOf<Theme>(*inbuiltThemes) |
Check warning
Code scanning / detekt
In most cases using a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty. Warning
There was a problem hiding this comment.
inbuiltThemes.toMutableList<Theme>()
There was a problem hiding this comment.
inbuiltThemes.toMutableList<Theme>()
You should use the "Add a suggestion" feature (bound to CTRL + G) instead. It adds some buttons for the PR author to add to the "commit batch", or directly commit it. When they commit it, the commit will also have you (the user making the suggestion) as the co-author.
| var themes = mutableListOf<Theme>(*inbuiltThemes) | |
| var themes = inbuiltThemes.toMutableList<Theme>() |
| FontManager.queueFolder(folder.resolve("assets")) | ||
| } | ||
|
|
||
| override fun init() { } |
Check warning
Code scanning / detekt
Empty block of code detected. As they serve no purpose they should be removed. Warning
| /* | ||
| * This file is part of LiquidBounce (https://github.com/CCBlueX/LiquidBounce) | ||
| * | ||
| * Copyright (c) 2024 CCBlueX |
There was a problem hiding this comment.
| * Copyright (c) 2024 CCBlueX | |
| * Copyright (c) 2024-2025 CCBlueX |
lol
| /* | ||
| * This file is part of LiquidBounce (https://github.com/CCBlueX/LiquidBounce) | ||
| * | ||
| * Copyright (c) 2024 CCBlueX |
There was a problem hiding this comment.
| * Copyright (c) 2024 CCBlueX | |
| * Copyright (c) 2024-2025 CCBlueX |
| @@ -1,7 +1,7 @@ | |||
| /* | |||
| * This file is part of LiquidBounce (https://github.com/CCBlueX/LiquidBounce) | |||
| * | |||
| * Copyright (c) 2015 - 2025 CCBlueX | |||
| * Copyright (c) 2024 CCBlueX | |||
There was a problem hiding this comment.
| * Copyright (c) 2024 CCBlueX | |
| * Copyright (c) 2024-2025 CCBlueX |
💀
|
This can only mean one thing... No more Chrome?!? |
I think this PR is deprecating legacy " |
|
nevermind, it's still web themes... |
|
It's just restructuring the theme system, that's it. Pretty much just turning moving like textures, wallpapers, and components from the metadata file into folders. I can probably update catppuccin for LiquidBounce to prepare for this because why not |
| ThemeManager.themes().filter { it.startsWith(s, true) } | ||
| ThemeManager.themes | ||
| .map { theme -> theme.name } | ||
| .filter { name -> name.startsWith(name, true) } |
There was a problem hiding this comment.
probably name.startsWith(s, true)
| get() = blur && !(mc.options.hudHidden && mc.currentScreen == null) | ||
|
|
||
| val layouts = choices("Layouts", 0) { | ||
| ThemeManager.themes.map { theme -> Layout(theme) }.toTypedArray() |
| return@onChange enabled | ||
| } | ||
| val inbuiltThemes = arrayOf(LiquidBounceTheme) | ||
| var themes = mutableListOf<Theme>(*inbuiltThemes) |
There was a problem hiding this comment.
inbuiltThemes.toMutableList<Theme>()
| value = mutableListOf( | ||
| *theme.components | ||
| .filter { factory -> factory.default } | ||
| .map { factory -> factory.createComponent(theme) }.toTypedArray() |
There was a problem hiding this comment.
value = theme.components. { ... }.toMutableList()
| tweaks: Array<ComponentTweak> = emptyArray() | ||
| ) : Component(theme, name, enabled, alignment, tweaks) { | ||
| abstract fun render(context: DrawContext, delta: Float) | ||
| abstract fun size(): Pair<Int, Int> |
There was a problem hiding this comment.
Maybe IntIntPair.of(x, y)
There was a problem hiding this comment.
I don't get why you'd want to use IntIntPair instead of Pair<Int, Int>...
|
|
||
| identifier | ||
| } | ||
| } ?: hashMapOf() |
|
This is just my playground for refactoring the theme system for better customization - as long as this is a draft, there is no need to review this code :) |
No that does not mean it. It means backwards compatibility with existing LiquidBounce Nextgen themes, as the changes are minor and mostly Data Format changes. |
I already knew that, if you scrolled down 2 messages... (also, you forgot a comma after "No", useless spelling gripe)
|
No description provided.