Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] JCEF Scroll Performance Bug #5653

Closed
1zun4 opened this issue Feb 17, 2025 · 1 comment
Closed

[BUG] JCEF Scroll Performance Bug #5653

1zun4 opened this issue Feb 17, 2025 · 1 comment
Labels
🐛 bug Something isn't working 🌑 nextgen
Milestone

Comments

@1zun4
Copy link
Member

1zun4 commented Feb 17, 2025

LiquidBounce Branch

Nextgen

LiquidBounce Build/Version

0.26.1

Operating System

Windows 11

Minecraft Version

1.21.4

Describe the bug

Scrolling will cause the FPS to drop a lot. It will probably cause a full repaint even though the DOM doesn't change at all. As @mems01 mentioned, this was not the case before, and must be some kind of bug that was introduced at some point and went unnoticed until now.

At least it cannot be caused by MouseScrollEvent as it is not a WebSocketEvent.

Steps to reproduce

  • Any GUI
  • Have FPS meter enabled
  • Scroll up and down
  • FPS drops

Client Log

-

Screenshots

No response

@1zun4 1zun4 added this to the 0.27.0 milestone Feb 17, 2025
@github-actions github-actions bot added 🌑 nextgen 🐛 bug Something isn't working labels Feb 17, 2025
1zun4 added a commit that referenced this issue Feb 17, 2025
Fixed oshi initialization on every scroll, which caused file descriptions to open and FPS to drop significantly.

#5653
1zun4 added a commit that referenced this issue Feb 17, 2025
Fixed oshi initialization on every scroll, which caused file descriptions to open and FPS to drop significantly.

#5653
@1zun4 1zun4 closed this as completed Feb 17, 2025
@1zun4
Copy link
Member Author

1zun4 commented Feb 17, 2025

The cause:
Image

I guess I'm not alone in this conclusion.
Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌑 nextgen
Projects
None yet
Development

No branches or pull requests

1 participant