Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mislead the users #7

Open
Kir-Antipov opened this issue Feb 24, 2023 · 5 comments
Open

Don't mislead the users #7

Kir-Antipov opened this issue Feb 24, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@Kir-Antipov
Copy link

My dear folks, dudes, and dudesses, author of mc-publish here.

Your modified README states:

This action is a fork mod-publish we never plan to merge back into upstream as it was considered out of scope for their project.

To be quite frankly honest with you, I do not remember saying something like that (welp, I don't remember not saying that either, so it may be on me). As a matter of fact, the state of things is quite the opposite to your claim, since I'm working not only on updating mc-publish to node16, but on implementing support for plugins and resource packs too. So it would be nice to see the description fixed :)

@chatcody
Copy link

chatcody bot commented Feb 24, 2023

A possible solution would be to update the README to reflect the changes you're making to mc-publish, such as adding support for plugins and resource packs. If more details are needed, please provide additional information in the issue.

@BrycensRanch
Copy link
Owner

Interesting, I must have misread Kir-Antipov#23 (comment) then. Glad to hear work is being done on the issue! The current idea of this project is:

Read asset data
Convert data where needed so we can publish
Publish via puppeteer if necessary (most of the time will be)

Per your request, I'll be updating the readme.

@BrycensRanch
Copy link
Owner

I'll leave this issue open in-case there are any concerns, thanks for reaching out to me.

@BrycensRanch BrycensRanch added the documentation Improvements or additions to documentation label Feb 28, 2023
@Kir-Antipov
Copy link
Author

To clarify my intentions regarding plugin support, when I said that Spigot and BuiltByBit support wouldn't be implemented the way srnyx described it, I simply meant that it would not be possible to automatically publish projects to these platforms, as there is no public API available for that, and creating an artifact, which the user then needs to manually copy and paste somewhere else, is out of scope of the goals of mc-publish as an approach (regardless of the project type).

I never meant to imply that plugin support was out of scope for mc-publish as a whole. In fact, we already have support for Bukkit (well, mostly, there's one slight issue that requires some work), as mentioned by Andre601, and I am considering adding Polymart support in the future, although it's not a high priority right now.

Anyway, thank you for showing interest in the project, I appreciate your interest and willingness to contribute. I'd be happy to merge support for Spigot and BuiltByBit, or any other platforms for that matter, if you were to implement a publishing mechanism using their internal API. This would allow users to publish their work seamlessly from within mc-publish without having to manually copy and paste their releases, which is the goal here. However, please be aware that mc-publish is currently undergoing maintenance, and many parts of it are being changed. Therefore, any new features added must be as isolated as possible to prevent any conflicts.

I hope this clears up any confusion, and please let me know if you have any further questions, concerns, and/or suggestions.

@BrycensRanch
Copy link
Owner

Understood 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants