Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coast.transect: scipy.integrate.cumtrapz deprecated #675

Open
1 task done
jdconey opened this issue Jan 24, 2025 · 1 comment · May be fixed by #676
Open
1 task done

coast.transect: scipy.integrate.cumtrapz deprecated #675

jdconey opened this issue Jan 24, 2025 · 1 comment · May be fixed by #676
Assignees
Labels
bug Something isn't working

Comments

@jdconey
Copy link

jdconey commented Jan 24, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Since scipy 1.14, integrate.cumtrapz has been removed in favour of integrate.cumulative_trapezoid. This is causing coast to fail to import when the latest versions of scipy are installed.

From my quick look at things, changing the transect script to import this new description should fix this behaviour.

Expected Behavior

import coast should have run without error.

Steps To Reproduce

  1. With a newish version of scipy installed (1.14 or later):
    import coast

Environment

- OS: Jasmin sci machine (system='Linux', node='sci-vm-01.jasmin.ac.uk', release='5.14.0-503.21.1.el9_5.x86_64', version='#1 SMP PREEMPT_DYNAMIC Wed Jan 8 17:35:30 UTC 2025', machine='x86_64')
- python: 3.10.2

Anything else?

No response

@jpolton
Copy link
Collaborator

jpolton commented Mar 3, 2025

Yes, replacing the implementations of integrate.cumptrapz to integrate.cumlative_trapezoid fixed this issue. I will create a branch and merge into develop
https://github.com/British-Oceanographic-Data-Centre/COAsT/tree/675_scipy_integrate_cumtrapz_update

@jpolton jpolton self-assigned this Mar 3, 2025
@jpolton jpolton added the bug Something isn't working label Mar 3, 2025
@jpolton jpolton linked a pull request Mar 4, 2025 that will close this issue
18 tasks
@jpolton jpolton removed a link to a pull request Mar 4, 2025
18 tasks
@jpolton jpolton linked a pull request Mar 4, 2025 that will close this issue
18 tasks
@jpolton jpolton linked a pull request Mar 4, 2025 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants