tidegauge.read_bodc() update

[jpolton]

See branch on PR

tidegauge.read_bodc() object has a different data structure from tidegauge.read_gesla() object. The latter is used more extensively and is assumed to be the template/default.

I noticed that the unit testing for objects created with tidegauge.read_bodc() was missing. So I cut and pasted the tests used for tidegauge.read_gesla() in unit_testing/test_tidegauge_methods.py. The test:

python -m pytest unit_testing/test_tidegauge_methods.py

has 2 errors, which look related to unexpected data shapes:

FAILED unit_testing/test_tidegauge_methods.py::test_tidegauge_methods::test_read_bodc_and_compare_to_model - AssertionError: False is not true : check1
FAILED unit_testing/test_tidegauge_methods.py::test_tidegauge_methods::test_tidegauge_cubic_spline_extrema - ValueError: operands could not be broadcast together with shapes (0,) (2,)

AC:

• Get unit_testing/test_tidegauge_methods.py working

Optional:

• The unit test code is repetitious - it may be better to test the objects created by read_gesla() and read_bodc() are as expected and then test the methods only once?