606 circulation and fluxes in global model data #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wrap Code to co-locate velocities on T-points and do a nice surface plot
1 task
|
@jasontempestholt I'm still going through this. I made some changes in a new branch they broke the unit_testing! So it is not ready yet. |
…obal-model-data_jp' into 606-circulation-and-fluxes-in-global-model-data_jp # Conflicts: # coast/diagnostics/circulation.py # unit_testing/test_diagnostic_methods.py
jpolton
requested changes
Mar 28, 2023
There was a problem hiding this comment.
I've taken your branch and:
- changed a few names to make them more COAsT
- abstracted and simplified your subsetting method in Gridded()
- refactored the velocity_on_t_points so that the differences across indices are not a function of dimension ordering (I'm also hoping it might scale better with xarray backend magic)
- updated to the latest version of Develop
- Unit testing still works.
One way to do this, so that it is still your branch, is if I request a merge into your branch. Then I will be ready to accept your branch.
NB there are a few name changes, which will affect your scripts (capitalisation mostly). These are the main (only?) two:
nemo_t = coast.CurrentsOnT(fn_domain=files.fn_nemo_dom, config=files.fn_config_t_grid, lims=lims)
nemo_t.currents_on_t(nemo_u, nemo_v)
This was referenced Mar 28, 2023
Closed
…rculation-and-fluxes-in-global-model-data_jp 606 circulation and fluxes in global model data jp
jpolton
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
COAsT-siterepo, in a separate PR. See contributing to documentation for details../build.sh) was run locally and no errors reported. NB not sure about this requirement: GitActions test thispylint .) has passed locally and any fixes were made for failures. NB not sure about this requirement: GitActions test this withblackPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: #
What is the new behavior?
Checklist
pip install . && pytest unit_testing/unit_test.py -s)Does this introduce a breaking change?
Other information
Quick update to add useful feature of subsetting for global models
and also some circulation calculations / plot, which will be further developed