Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last changed #25

Closed
JohnCoene opened this issue Oct 6, 2023 · 5 comments · May be fixed by #119
Closed

Last changed #25

JohnCoene opened this issue Oct 6, 2023 · 5 comments · May be fixed by #119
Assignees
@DivadNojnarg
Labels
enhancement New feature or request question Further information is requested

Comments

@JohnCoene
Copy link
Member

https://github.com/blockr-org/blockr/blob/7ce63509150b04800dac628f38ea4d9c77819367/R/ui.R#L62

I don't understand why we do this? @DivadNojnarg
@DivadNojnarg
Copy link
Collaborator

This was to get the index of the clicked remove button to be able to cleanup the stack (the buttons are in the block modules not in the stack). However, there could be better ways now.

@JohnCoene
Copy link
Member Author

OK, could you remove the console.log please?

@DivadNojnarg
Copy link
Collaborator

Done

@DivadNojnarg DivadNojnarg added the question Further information is requested label Oct 10, 2023
@DivadNojnarg DivadNojnarg mentioned this issue Dec 4, 2023
Closed
@DivadNojnarg DivadNojnarg added the enhancement New feature or request label Dec 5, 2023
@DivadNojnarg
Copy link
Collaborator

To be removed ...

@DivadNojnarg DivadNojnarg self-assigned this Dec 5, 2023
@DivadNojnarg DivadNojnarg mentioned this issue Dec 5, 2023
Open
@DivadNojnarg
Copy link
Collaborator

Closed in #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DivadNojnarg DivadNojnarg

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup module: block, stack ... BristolMyersSquibb/blockr
2 participants
@JohnCoene @DivadNojnarg