From bf09c191a6a0fcb1c9854dfa466a8b33b3165d7f Mon Sep 17 00:00:00 2001 From: Ian Cooper Date: Wed, 5 Feb 2025 09:59:19 +0000 Subject: [PATCH] fix: consumer was checking for null, but EnsureChannel creates later --- .../RmqMessageConsumer.cs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Paramore.Brighter.MessagingGateway.RMQ.Sync/RmqMessageConsumer.cs b/src/Paramore.Brighter.MessagingGateway.RMQ.Sync/RmqMessageConsumer.cs index b3bdd5e85..395406739 100644 --- a/src/Paramore.Brighter.MessagingGateway.RMQ.Sync/RmqMessageConsumer.cs +++ b/src/Paramore.Brighter.MessagingGateway.RMQ.Sync/RmqMessageConsumer.cs @@ -267,9 +267,7 @@ public void Reject(Message message) /// Message. public Message[] Receive(TimeSpan? timeOut = null) { - if (_consumer is null) - throw new InvalidOperationException("RmqMessageConsumer.Receive - value of _consumer cannot be null"); - + if (Connection.Exchange is null) throw new InvalidOperationException("RmqMessageConsumer.Receive - value of Connection.Exchange cannot be null"); @@ -290,7 +288,8 @@ public Message[] Receive(TimeSpan? timeOut = null) { EnsureChannel(); - var (resultCount, results) = _consumer.DeQueue(timeOut.Value, _batchSize); + //NOTE: EnsureChannel means that _consumer cannot be null + var (resultCount, results) = _consumer!.DeQueue(timeOut.Value, _batchSize); if (results != null && results.Length != 0) {