Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Transient dependency sentencepiece requires cmake to install correctly. #6

Open
CalebCourier opened this issue Nov 18, 2024 · 1 comment

Comments

@CalebCourier
Copy link

sentencepiece, a dependency of unbabel-comet requires cmake when building its wheel. Since many environments do not include cmake by default, it would be useful to add a note to this validator's README to mention this requirement.

On Linux and MacOS this information can be gleaned from the error show, but the Windows error is not as transparent to the root cause of the installation failure. See this issue for an example of the Windows error: guardrails-ai/guardrails#1167

@CalebCourier
Copy link
Author

Update on this behaviour:

In addition to cmake, when installing sentencepiece<0.2.x (a transient dependency of this validator), it also requires other C++ build tools such as g++. This is noted in their README here: https://github.com/google/sentencepiece?tab=readme-ov-file#build-and-install-sentencepiece-command-line-tools-from-c-source

It also appears that this is only needed in versions of python 3.12 and above since there are wheels published for the versions below this and thus the wheel does not need to be built on the client machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant