-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging #124
Comments
Yes. We've been planning to do this for a while, so yeah it would be an
awesome addition.
Please create a Pull Request once its done and set me as reviewer.
…On Thu, Jun 8, 2017 at 6:30 AM Roman Kravchenko ***@***.***> wrote:
@alvin-reyes <https://github.com/alvin-reyes> fb-botmill logs everything
to console. Can I make it to put logs in a file?
Thanks in advance.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#124>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AERYw_qeY1xq5nbxa2oorp6f73-7TJjlks5sB81VgaJpZM4Nz4Lv>
.
|
I would suggest not to pack logback.xml in the jar file. Let the user decide where and what to log |
@andrefsore , do you have any suggestion how can we do it better? |
The developer who imports the lib, should create theirs own logback.xml. I had to create logback-test.xml in order to override logback.xml that was packed in fb-botmil.jar, because I wanted to set the logging level by myself, for instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@alvin-reyes fb-botmill logs everything to console. Can I make it put logs in a file?
Thanks in advance.
The text was updated successfully, but these errors were encountered: