From 52bf6a7415b992b2d09132032cbfdb3d317a9128 Mon Sep 17 00:00:00 2001
From: Michael Kirschner <508936+mjkkirschner@users.noreply.github.com>
Date: Tue, 4 Mar 2025 16:29:56 -0500
Subject: [PATCH] multi target build does not build on master-15 (#15890)

---
 src/NodeServices/DynamoServices.csproj | 50 ++++++++++++++------------
 1 file changed, 27 insertions(+), 23 deletions(-)

diff --git a/src/NodeServices/DynamoServices.csproj b/src/NodeServices/DynamoServices.csproj
index 1ffdfada74f..caae8a34e55 100644
--- a/src/NodeServices/DynamoServices.csproj
+++ b/src/NodeServices/DynamoServices.csproj
@@ -1,24 +1,28 @@
-<Project Sdk="Microsoft.NET.Sdk">
-  <ImportGroup Label="PropertySheets">
-    <Import Project="$(SolutionDir)Config\CS_SDK.props" />
-  </ImportGroup>
-  <PropertyGroup>
-    <ProductVersion>8.0.30703</ProductVersion>
-    <SchemaVersion>2.0</SchemaVersion>
-    <ProjectGuid>{EF879A10-041D-4C68-83E7-3192685F1BAE}</ProjectGuid>
-    <OutputType>Library</OutputType>
-    <AppDesignerFolder>Properties</AppDesignerFolder>
-    <RootNamespace>DynamoServices</RootNamespace>
-    <AssemblyName>DynamoServices</AssemblyName>
-    <DocumentationFile>$(OutputPath)\DynamoServices.XML</DocumentationFile>
-    <TargetFrameworks>netstandard2.0;net8.0;</TargetFrameworks>
-    <TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>
-  </PropertyGroup>
-  <PropertyGroup>
-    <NoWarn>MSB3539;CS1591;NUnit2005;NUnit2007;CS0618;CS0612;CS0672</NoWarn>
-  </PropertyGroup>
-  <ItemGroup>
-      <!--exclude these dependencies as Sys.Ref.MetadataLoadContext.dll is already pulled in from other projects and the transitive deps are part of the .net8 runtime.-->
-    <PackageReference Include="System.Reflection.MetadataLoadContext" Version="8.0.0" ExcludeAssets="runtime" />
-  </ItemGroup>
+<Project Sdk="Microsoft.NET.Sdk">
+    <ImportGroup Label="PropertySheets">
+        <Import Project="$(SolutionDir)Config\CS_SDK.props" />
+    </ImportGroup>
+    <PropertyGroup>
+        <ProductVersion>8.0.30703</ProductVersion>
+        <SchemaVersion>2.0</SchemaVersion>
+        <ProjectGuid>{EF879A10-041D-4C68-83E7-3192685F1BAE}</ProjectGuid>
+        <OutputType>Library</OutputType>
+        <AppDesignerFolder>Properties</AppDesignerFolder>
+        <RootNamespace>DynamoServices</RootNamespace>
+        <AssemblyName>DynamoServices</AssemblyName>
+        <DocumentationFile>$(OutputPath)\DynamoServices.XML</DocumentationFile>
+        <!--seems like an msbuild build bug - if both targetframework and
+      targetframeworks are set targetframeworks is ignored
+      even though it should take precedence according to the docs.
+      Dotnet build and builds in vs seem to work fine without this hack.-->
+        <TargetFramework>$(Undefined)</TargetFramework>
+        <TargetFrameworks>netstandard2.0;net8.0;</TargetFrameworks>
+    </PropertyGroup>
+    <PropertyGroup>
+        <NoWarn>MSB3539;CS1591;NUnit2005;NUnit2007;CS0618;CS0612;CS0672</NoWarn>
+    </PropertyGroup>
+    <ItemGroup>
+        <!--exclude these dependencies as Sys.Ref.MetadataLoadContext.dll is already pulled in from other projects and the transitive deps are part of the .net8 runtime.-->
+        <PackageReference Include="System.Reflection.MetadataLoadContext" Version="8.0.0" ExcludeAssets="runtime" />
+    </ItemGroup>
 </Project>
\ No newline at end of file