Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to auto-format or enforce formatting rules for config files #159

Open
kehoecj opened this issue Aug 5, 2024 · 4 comments
Labels
validator-core Issues that relate to the core validator functionality

Comments

@kehoecj
Copy link
Collaborator

kehoecj commented Aug 5, 2024

Requested by a user here

@kehoecj kehoecj added the validator-core Issues that relate to the core validator functionality label Aug 5, 2024
@21Average
Copy link

I’m interested in collaborating on this if you haven’t begun yet. I prefer add a -format flag, Here’s my proposed approach:

  1. add a -format flag.
  2. Create a new package called Formatter.
  3. Modify the Run function in cli.go to format files after they’ve been validated (only formatting validated files).

Should we modify the existing files, or would it be better to create new ones?

@kehoecj kehoecj added the hacktoberfest 🎃 Hacktoberfest 2024 label Oct 2, 2024
@kehoecj
Copy link
Collaborator Author

kehoecj commented Oct 2, 2024

@21Average It's yours to work on if you'd like. I think your approach makes sense. Please do an initial config type (XML, JSON, YAML, whichever) then put it up for an initial MR review

@kehoecj
Copy link
Collaborator Author

kehoecj commented Oct 23, 2024

@21Average Haven't seen a PR in 3 weeks so I'm unassigning you so someone else can pick it up before hacktoberfest is over

@kehoecj kehoecj removed the hacktoberfest 🎃 Hacktoberfest 2024 label Nov 1, 2024
@Kashugoyal
Copy link
Contributor

@kehoecj is it cool if I take it over. This should be a quick one. I will start by adding the formatter just for json and later we can others in separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validator-core Issues that relate to the core validator functionality
Projects
None yet
Development

No branches or pull requests

3 participants