Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The message for NotDefault() is confusing #2

Open
ljhca opened this issue Mar 21, 2019 · 4 comments
Open

The message for NotDefault() is confusing #2

ljhca opened this issue Mar 21, 2019 · 4 comments
Assignees
Labels

Comments

@ljhca
Copy link

ljhca commented Mar 21, 2019

When the .NotDefault() Precondition fails, the exception message is:

System.ArgumentException : Bookedtime
"Parameter name: Value must have default value!"

Why would we say that it must have a 'default value' when the condition is that it is NOT the default value?

I think something like:
"Parameter name: Must have a value other than the system default"

@BoasE
Copy link
Owner

BoasE commented Mar 21, 2019

oh you are right. this should be changed.

@BoasE BoasE added the bug label Mar 21, 2019
@BoasE BoasE self-assigned this Mar 21, 2019
@BoasE
Copy link
Owner

BoasE commented Mar 21, 2019

Feel free to make a pr otherwise I'll change it

@SebastianStehle
Copy link

I would add the default value to the message.

@BoasE
Copy link
Owner

BoasE commented Mar 21, 2019

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants