Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not an issue but more a suggestion on a possible Gloom AO improvement :) #9

Open
Deus-nsf opened this issue Sep 25, 2021 · 1 comment

Comments

@Deus-nsf
Copy link

Deus-nsf commented Sep 25, 2021

First let me start by saying that I really love this Gloom AO shader, it is working incredibly well on many games in Halo MCC for example.

However I have a little "problem" with it, during many sequences, the screen will fade to almost pitch black, for example black bars, or fade to black effects (but it's not perfect black though), and you can see the geometry and the AO glitching through the black bars and all because the depth buffer is still available.

I was wondering if it could be possible to have a color threshold option to ignore the AO when the scene is too dark, to avoid AO leaking during cinematic presentations or darker environments. I noticed the "Color Power" option can act as a sort of threshold for ignoring the AO in parts of the scene that are too bright, maybe it can have an other option similar to this but repurposed for dark scenes?

Thanks for reading!

I do have some performance concerns as well, as even in quarter res the shader has a huge impact on the GPU, but I am playing at 4K and beyond so it's partially on me haha.

@BlueSkyDefender
Copy link
Owner

I will add this when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants