Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadiantGI not honoring reshade depth preprocessors #22

Open
TerrorizedGakon opened this issue Aug 16, 2024 · 2 comments
Open

RadiantGI not honoring reshade depth preprocessors #22

TerrorizedGakon opened this issue Aug 16, 2024 · 2 comments

Comments

@TerrorizedGakon
Copy link

TerrorizedGakon commented Aug 16, 2024

Hi,

I unfortunately found an annoying problem with the shader - it does not take into consideration preprocessor directives like RESHADE_DEPTH_INPUT_X_SCALE or RESHADE_DEPTH_INPUT_LINEARIZATION_FAR_PLANE.

So, to me, the shader was totally unusable, until I modified it a tiny bit. Adding support for RESHADE_DEPTH_INPUT_X_SCALE was not diffcult for somebody who can't code at all, all it took is copying lines from reshade.fxh to the correct place... but implementing RESHADE_DEPTH_INPUT_LINEARIZATION_FAR_PLANE is not something I can do..

Would it be diffcult for you to modify the shader to respect these preprocessors? So the shader can be used in non standard cases where the depth buffer needs to be altered.. or in conjuction with other shaders like MXAO, which have support for these directives.

Thanks

@BlueSkyDefender
Copy link
Owner

BlueSkyDefender commented Aug 16, 2024 via email

@TerrorizedGakon
Copy link
Author

TerrorizedGakon commented Aug 16, 2024

Shader is in a rewrite phase. And will have a new system implemented later.

Hey, that's great. Thanks for the information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants