Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert s_agent_rewards to a policy and the three s_total_reward mechanisms to just take it in as an input #296

Open
SeanMcOwen opened this issue May 14, 2024 · 1 comment
Open

Convert s_agent_rewards to a policy and the three s_total_reward mechanisms to just take it in as an input #296

SeanMcOwen opened this issue May 14, 2024 · 1 comment
Labels
model-dev Tier4

Comments

@SeanMcOwen
Copy link
Contributor

The four functions are just copies of the same exact code returning different things. Really inefficient and dangerous to not having changes updated in all places
@jackhack00
Copy link
Contributor

sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
model-dev Tier4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SeanMcOwen @jackhack00