When the browser location defined in the test-runner.conf is wrong no error is logged in the console (dashboard)

[andy-berry-dev]

https://jira.caplin.com/browse/PCTCUT-608

If the test-runner.conf file has the browser location incorrectly defined it throws a message in the dashboard saying: "Error running tests. Check BladeRunner console for error messages."

Howeeer, the BladeRunner Console doesn't give an error message, it simply says:

"
Writing HTML reports to ../test-results/html.
Starting server process...

Time Taken: 2secs "
However, when you are running from the command prompt "bladerunner test ../apps/fxtrader", you get an error message like you would expect.

[andy-berry-dev]

The exceptions around this have been improved.
@sospirited when you have a sec can you check you're happy then we can close this.

[sospirited]

There are 2 things here:

1. When you have the default test-runner.conf (no browsers defined)
2. When you have modified the default test-runner.conf to have a browser path which is invalid

With 1) and 2), the dashboard displays this:

However, with #1 there is nothing output to the console

With #2 the following is output to the console:

2014-04-30 11:41:08,148 [qtp628578205-27] INFO  brjs.command.TestRunner - Starting server process...
2014-04-30 11:41:09,338 [Thread-21] INFO  brjs.util.ProcessLogger - serverWARN: Attempt to start a started server
2014-04-30 11:41:10,266 [qtp628578205-27] INFO  brjs.command.TestRunner -

2014-04-30 11:41:10,267 [qtp628578205-27] INFO  brjs.command.TestRunner - - Time Taken: 2secs
2014-04-30 11:41:10,267 [qtp628578205-27] INFO  brjs.command.TestRunner -

2014-04-30 11:41:10,316 [qtp628578205-27] INFO  brjs.command.TestRunner - Writing HTML reports to ../test-results/html.
2014-04-30 11:41:10,756 [qtp628578205-27] INFO  brjs.command.TestRunner - ERROR: org.bladerunnerjs.model.exception.test.BrowserNotFoundException: Could not find the browser 'C:\Program Files\Google\Chrome\Application\chrome.exe' on disk. Please check your test config inside
 'D:\Development\git\brjs\cutlass-sdk\workspace\conf'

[ioanalianabalas]

@sospirited, the first point does not seem to be relevant to BladeRunnerJS. Please let us know if you think this may not be the case.

Otherwise, PR #1141 fixes console-related issues for when the browsers have not been found.

[thecapdan]

@ioanalianabalas on the first point, i think we used to by default not define a browser, but now the default is to use chrome, so we no longer need to worry about it:)

I reproduced the second issue, and I only get the following error in the console:

Writing HTML reports to ../test-results/html.
ERROR: d:\repo\brjs\brjs-sdk\workspace\sdk\..\test-results\xml does not exist.

I'm assuming we are meant to see a new exception, but it is not making it to the console

[ioanalianabalas]

@thecapdan, I have retested the functionality, and we are currently seeing this message on the dashboard:

You are right about the console, though - there are no additional messages there. I am fixing this now.

[ioanalianabalas]

After a discussion with @dchambers, we have decided to postpone this issue, because we intend on changing the way the tests run to use the model rather than the commands.