Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Restore function] Make "copy link" button create full link with http/https in front #2069

Closed
themerekat opened this issue Jan 15, 2025 · 1 comment
Assignees

Comments

@themerekat
Copy link
Collaborator

When you click the "download link" button from a search, it doesn't append "https://" to the beginning of the link, which makes copying and pasting the link slightly less convenient (it doesn't always automatically create a link in word processors and emails).
image

Example:
cch2.org/portal/collections/list.php?db=123&comingFrom=newsearch

@egbot
Copy link
Member

egbot commented Jan 15, 2025

Another dev request is reducing the size of the copied link, which makes it easier to share. The code within 3.1 Master branch removes all empty variables plus the db variable if "all" is listed (e.g. db=all%2C5%2C70%2C99), which is equivalent to it being empty. However, it seems like this functionality has been removed from the current Dev branch. The code in the master branch also converts the %2C to commas, which don't need to be encoded. Commas also don't need to be encoded to %2C in the url, or the search form could be converted to a POST method so that the URL is not displayed, which is what the old form did and why the copy link button was add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants