Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop getting data if player stop beign rendered #8

Open
alecshoppe opened this issue Aug 27, 2020 · 0 comments
Open

Stop getting data if player stop beign rendered #8

alecshoppe opened this issue Aug 27, 2020 · 0 comments

Comments

@alecshoppe
Copy link

alecshoppe commented Aug 27, 2020 •
edited
Loading

The problem: every time you render a react-flv-player on your screen the player will get the network packages and if you remove from the DOM this player it still getting the video packages.
Solution: .destroy function from flv.js is not implemented in this library and should be.

My solution was this:
https://github.com/alecshoppe/react-flv-player/blob/patch-1/lib/wrapper/ReactFlvPlayer.js
alecshoppe added a commit to alecshoppe/react-flv-player that referenced this issue Aug 27, 2020
@alecshoppe
Update network performance bug
099a0c3 
Review this code before publishing.
This code should fix BingXiong1995#8 problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alecshoppe