Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes are not deleted after X days from trash #151

Open
AndhikaWB opened this issue Oct 6, 2019 · 3 comments
Open

Notes are not deleted after X days from trash #151

AndhikaWB opened this issue Oct 6, 2019 · 3 comments

Comments

@AndhikaWB
Copy link

Notes (in Trash) are not getting deleted automatically, they stay forever in my Google Drive storage.

My guess is that the (new) introduced sync feature does not check for date of notes. It will sync from cloud if notes don't exist on local storage (especially on a clean install of Scarlet Notes) and will make the date of old notes got renewed again and again.

I'm not sure about notes that are deleted permanently (without going through Trash) but I hope they are deleted from my Google Drive for real.

@BijoySingh
Copy link
Owner

Ah, that is an interesting bug.

I wasn't able to reproduce this exactly. But I am adding some additional logic to delete notes. Could it be you are using multiple devices which have different times / timezones, that can cause such weird issues.

@BijoySingh
Copy link
Owner

caf5064

@AndhikaWB
Copy link
Author

I'm just using one device. I recently flashed a custom ROM so all my data are lost and I reinstalled Scarlet Notes (Pro).

Then I started to notice that old (deleted) notes are appearing on Scarlet Notes home screen (after syncing) for few seconds before disappearing again. Because of that, I checked my trash and noticed that my old notes in trash are not getting deleted automatically after X days (I'm quite sure some of them are already in trash long ago before I even flashed the custom ROM).

Today, I do a cross check on my Google Drive and indeed, all my old (deleted) notes are inside the Scarlet (App Data) -> notes, they are not truly deleted. Although they also don't appear on my Scarlet Notes for now (except on the first sync that I stated before).

So there are 2 guess:

  • Notes in trash are deleted (locally) after X days but got redownloaded on a new install of Scarlet Notes (since the deleted notes stay on Google Drive)
  • Notes in trash are not getting deleted automatically at all (so they stay forever on both local and Google Drive). I can't check this one, my trash is currently empty, though.

Please take a note that I haven't tried deleting notes in trash manually. They may have a different behavior on a clean install of Scarlet Notes (they may/may not appear again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants