From 07d5f77a99f9e24233f9cc1b64f727286984fbb9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20M=C3=BCller?= Date: Mon, 6 May 2024 00:09:07 +0200 Subject: [PATCH] Fix resolving assembly issue for `Microsoft.Extensions.DependencyInjection.Abstractions` (#1654) * changed order of assembly resolvers * update change log --------- Co-authored-by: David Mueller x --- Documentation/Changelog.md | 1 + src/coverlet.core/Instrumentation/CecilAssemblyResolver.cs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/Changelog.md b/Documentation/Changelog.md index e45171b6f..e56b0b685 100644 --- a/Documentation/Changelog.md +++ b/Documentation/Changelog.md @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased ### Fixed +- Fix Unable to instrument module - NET 8 [#1631](https://github.com/coverlet-coverage/coverlet/issues/1631) - Fix slow modules filtering process [#1646](https://github.com/coverlet-coverage/coverlet/issues/1646) by https://github.com/BlackGad - Fix incorrect coverage await using in generic method [#1490](https://github.com/coverlet-coverage/coverlet/issues/1490) diff --git a/src/coverlet.core/Instrumentation/CecilAssemblyResolver.cs b/src/coverlet.core/Instrumentation/CecilAssemblyResolver.cs index 49790660e..7a6f1070a 100644 --- a/src/coverlet.core/Instrumentation/CecilAssemblyResolver.cs +++ b/src/coverlet.core/Instrumentation/CecilAssemblyResolver.cs @@ -76,9 +76,9 @@ public NetstandardAwareAssemblyResolver(string modulePath, ILogger logger) // runtime folders are different _compositeResolver = new Lazy(() => new CompositeCompilationAssemblyResolver(new ICompilationAssemblyResolver[] { + new NetCoreSharedFrameworkResolver(modulePath, _logger), new AppBaseCompilationAssemblyResolver(), new PackageCompilationAssemblyResolver(), - new NetCoreSharedFrameworkResolver(modulePath, _logger), new ReferenceAssemblyPathResolver(), }), true); }