Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0.0-beta-24 no "early media" Option #2301

Closed
fseebach opened this issue Jan 7, 2025 · 23 comments
Closed

6.0.0-beta-24 no "early media" Option #2301

fseebach opened this issue Jan 7, 2025 · 23 comments

Comments

@fseebach
Copy link

fseebach commented Jan 7, 2025

I tried 6.0.0-beta-24 because of 2151.
The issue from 2151 is fixed. Great.

But im facing a new Problem in beta-24.
In Linphone-Android 5 i could activate Early Media and it worked great in my Setup.

In beta-24 there is no "early media" option to activate. Should this work out of the Box? Or is early media not implemented in v6? Will it be implemented?

@fseebach
Copy link
Author

fseebach commented Jan 7, 2025

To clarify (after reading: #2198)

I mean early media send by the caller to my LinphoneAndroid Phone. Maybe it would work in v5 even without activating "early media" option?

However,

early media send by the CALLER to my Linphone Android works in V5 and doesnt in V6

@fseebach
Copy link
Author

fseebach commented Jan 7, 2025

Checked V5 again.

Early media from caller to LinphoneAndroid only works if "early media" Option is aktivated in Linphone

@Viish
Copy link
Member

Viish commented Jan 7, 2025

Hi @fseebach,

Indeed the early-media setting is mandatory for the Android client to answer 183 instead of 180.
It's not done yet in the 6.0 release but yes it will eventually be part of it.

Cheers,

@fseebach
Copy link
Author

fseebach commented Jan 7, 2025

nice to hear that. Will you Update this issue when theres an RC with early media enabled? Would love to test it as soon as possible. Or is there any other way to track progress of V6?

@Viish
Copy link
Member

Viish commented Jan 8, 2025

Will you Update this issue when theres an RC with early media enabled?

Yes, I'll close this issue when the feature will be implemented.

@Viish
Copy link
Member

Viish commented Jan 8, 2025

@fseebach I've added the setting in branch feature/accept_early_media_setting but I can't test it right now if you want to give it a try.

@fseebach
Copy link
Author

fseebach commented Jan 8, 2025

@Viish cannot find the branch feature/accept_early_media_setting

@fseebach
Copy link
Author

fseebach commented Jan 8, 2025

Hey @Viish
it doesnt work for me. Tried it again in V5 to be sure. In V5 it works perfectly.

Debug Log: https://pastebin.com/75gxfnXr (expires in 24 hours)

As soon as i answer the Call, video is working as expected.

@fseebach
Copy link
Author

fseebach commented Jan 8, 2025

Looks even worse. Sometimes if i answer the call Video is not Starting, all buttons are locked and i have to force kill the app.

Tried multiple times with Early Media on and off.
Crash only happens with early media ON
(i dont think it really crashes, just the buttons do nothing, if i minimze the app the call is continued in notification tray)

@fseebach
Copy link
Author

fseebach commented Jan 8, 2025

I can reproduce the freeze:

It does NOT happen if i answer the call from the notification directly.

If first click the Notification (to see early media), wait there for an extended period of time (i guess more than 5 seconds) and answer the call => all buttons are frozen and i have to kill the app.

if i click the notification and immediatly answer the call on the next screen => NO freeze

@Viish
Copy link
Member

Viish commented Jan 8, 2025

Commit ID 3cd3806f3a8ec41fd73537aa3ffc8cd374b3f40c from same branch should fix video not being displayed (as I said I merely added the setting in my previous commit).
If you still have the freeze/crash, please attach the stack trace & new logs.

@fseebach
Copy link
Author

fseebach commented Jan 8, 2025

great... works as expected now! video shows, no crash!

One little thing left: Theres an overlay over the video (the circle with a letter inside and the caller id below). I guess that should be moved somewhere else if video is enabled.

@fseebach
Copy link
Author

fseebach commented Jan 8, 2025

sorry... ui still freezes if i wait long enough at the video preview. Will attach logs

@fseebach
Copy link
Author

fseebach commented Jan 8, 2025

Logs: https://pastebin.com/gJRm4YMa (expires in 24h)

I truncated the log because it gets realy big.. the error is constantly repeated:

2025-01-08 15:30:09:581 [org.linphone/mediastreamer] ERROR [TextureView Display][Filter=0xb400006e592f6d30] eglSwapBuffers failure for windowId 0x5806: 0

@Viish
Copy link
Member

Viish commented Jan 8, 2025

Indeed something very wrong is happening (I don't reproduce it all the time).
I'll investigate and let you know (I'll only merge the branch when it will be fixed).

@Viish Viish added the type: bug label Jan 8, 2025
@fseebach
Copy link
Author

fseebach commented Jan 9, 2025

@Viish
just tried out the newest commits... works like a charm now!

@fseebach
Copy link
Author

fseebach commented Jan 9, 2025

im sorry... still got the case that after accepting the call no video is shown and i cannot click the hang up button...
but it seems to happen not as often..

@Viish
Copy link
Member

Viish commented Jan 9, 2025

Yes I'm aware this issue still happens, that's why I haven't merged it yet.
We're working on it.

@Viish
Copy link
Member

Viish commented Jan 13, 2025

Hi @fseebach,

I just fixed the deadlock on the feature/accept_early_media_setting branch.
Turns out it wasn't related to early-media at all, but for some reason issue was more likely to happen in this scenario.

Cheers,

@Viish Viish closed this as completed Jan 13, 2025
@Viish
Copy link
Member

Viish commented Jan 13, 2025

I'll do a few more tests and then merge the branch into master.

@fseebach
Copy link
Author

@Viish
nice to hear that. When will this be available in the PlayStore Beta channel?

@Viish
Copy link
Member

Viish commented Jan 13, 2025

When will this be available in the PlayStore Beta channel?

I'll push a new beta this afternoon, so it should be available in a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants