Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filterLocation property from the evaluator #303

Open
Nusiq opened this issue Dec 15, 2024 · 0 comments
Open

Remove filterLocation property from the evaluator #303

Nusiq opened this issue Dec 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Nusiq
Copy link
Member

Nusiq commented Dec 15, 2024

The Go-Simple-Eval evaluator gets a property called filterLocation. It's not documented and it doesn't seem to make much sense in the context in which we use the evaluator especially with that name.

Same with settings it doesn't seem to work properly.

"filterLocation": ctx.AbsoluteLocation,
"settings": ctx.Settings,

@Nusiq Nusiq added the bug Something isn't working label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant