Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable melee.gg team scraping #12

Open
Badaro opened this issue Jun 12, 2024 · 0 comments
Open

Re-enable melee.gg team scraping #12

Badaro opened this issue Jun 12, 2024 · 0 comments

Comments

@Badaro
Copy link
Owner

Badaro commented Jun 12, 2024

Team tournament scraping had to be disabled in melee.gg (with a very ugly "blacklist" hack) because right now there's no good way to scrape these:

  1. GetRoundStandings only returns the first decklist, even if it's a team tournament
  2. GetPlayerDetails returns the decklist, but not the format
  3. However, the ordering of formats is not consistent, so we also need the format to reorder them

Any option I could find would require multiple http hits per player to get this information, and the performance was unacceptably slow, even testing was difficult due to how long it would take.

I suspect the GetRoundStandings behavior is a bug on melee and will be fixed sooner or later, so when/if that happens I can review the code and re-enable team tournaments.

In that scenario, we need to scrape back those events from May/2024 onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant