Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification of results for structural adapters #450

Open
peterjamesnugent opened this issue Jan 20, 2021 · 6 comments
Open

Verification of results for structural adapters #450

peterjamesnugent opened this issue Jan 20, 2021 · 6 comments
Assignees
Labels
severity:critical No workaround exists. Essential to continue type:test-script Creation of unit test required

Comments

@peterjamesnugent
Copy link
Member

peterjamesnugent commented Jan 20, 2021

Definition of the test :

I've produced a script to create two (for now) simple models:

  • A simply supported beam,
  • A free standing column

A number of different loads are applied:

  • Bar uniformly distributed load
  • Shear Y and Shear Z applied at mid span
  • Torsion applied at free end
  • Axial force applied at free end

For this toolkit can you please run the script to create the model, analyse the model and verify that the results are pulled.

This is also a good opportunity to ensure the results follow the BHoM's Structural Conventions.

Please save your model in an appropriate folder in this location.

The script to push the generic models can be found here.

Also it should be noted that you will be required to reinitialise the AdapterId components (I've highlighted them in red) - see here for the issue: BHoM/BHoM_Adapter#283.

@peterjamesnugent peterjamesnugent added severity:critical No workaround exists. Essential to continue type:test-script Creation of unit test required labels Jan 20, 2021
@peterjamesnugent peterjamesnugent added this to the BHoM 4.1 β RC milestone Jan 20, 2021
@peterjamesnugent
Copy link
Member Author

It also worth noting that the models I have created are in SI Units - so unless this toolkit implements the Units_Engine it should also be in SI Units to allow easy comparison of results between calculated and expected values.

@markrocha
Copy link

Hi @peterjamesnugent,

I tried a similar test in which I added distributed loads to an open session of a Robot model. Whenever I added the distributed line load, the value of the load does not come across. I've tried the three different UDL nodes as well as creating BHoM Vectors or native Grasshopper Vectors. It appears whatever value I try to write to, it appears in Robot as a 0.00 value while the others are a 0.0 value. I am using Robot 2020 and also tried this on Robot 2016 and got the same behavior. I'm in the process of trying to test it out on Robot 2019. My BHoM version is 4.2.10

I did try this same test on SAP2000 and ETABS with success - i.e. load values from a vector came across.

image

image

Let me know if this may be better placed as a separate Issue-

Thanks!

@markrocha
Copy link

One last comment - when I pull the UDL from the model and explode the force, I get a value. Strange -
image

@peterjamesnugent
Copy link
Member Author

Hi @markrocha I notice that your load does not have a name associated with it - could you try giving it a unique name (i.e. 1 load : 1 name).

If that doesn't work could you send over your script in .zip file?

I've attached our standard script below:
StandardBeamModels.zip

@IsakNaslundBh
Copy link
Contributor

One last comment - when I pull the UDL from the model and explode the force, I get a value. Strange -

Hi @markrocha .

I would check the units here. BHoM is always in unfactored SI. This means that the force vector for a Bar UDL has the unit Newtons per metre. 1 N/m is equal to 0.000068522kip/ft, so wonder if that could be the explanation to what is going on here, and why you can't see the value in robot (rounded away from the UI) but get a value when you pull it back.

Hope this could help.

@markrocha
Copy link

Thank you @peterjamesnugent and @IsakNaslundBh ! That was the trick. I'm the US so I assume everything is imperial (LOL) - thanks for the reminder. See below for the change in the script.
image

image

I did notice that the load nature was not translating across. It's not a big deal, but it could be something on my end. I assigned the load nature as wind and it came across as dead.

image
image

I'm looking forward to when the https://github.com/BHoM/Robot_Toolkit/wiki/BHoM-Robot-object-relations allow us to include updating UDL. I intend to help where I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:critical No workaround exists. Essential to continue type:test-script Creation of unit test required
Projects
None yet
Development

No branches or pull requests

3 participants