Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rhino_Toolkit : List<ISurface>.ToRhino not returning closed Brep from BHoM.BoundaryRepresentation #91

Open
al-fisher opened this issue Apr 24, 2019 · 4 comments
Open

Rhino_Toolkit : List<ISurface>.ToRhino not returning closed Brep from BHoM.BoundaryRepresentation #91

al-fisher opened this issue Apr 24, 2019 · 4 comments
Assignees
@LMarkowski @michaelhoehn
Labels
type:bug Error or unexpected behaviour

Comments

@al-fisher
Copy link
Member

Failure in method below to effectively close/join the Rhino Brep after creation.

public static RHG.Brep ToRhino(this List<BHG.ISurface> surfaces)

image
@al-fisher al-fisher added the type:bug Error or unexpected behaviour label Apr 24, 2019
@al-fisher al-fisher mentioned this issue Apr 24, 2019
Merged
@al-fisher
Copy link
Member Author

New test files provided here:

https://burohappold.sharepoint.com/sites/BHoM/02_Current/Forms/AllItems.aspx?RootFolder=%2Fsites%2FBHoM%2F02%5FCurrent%2F12%5FScripts%2F01%5FTest%20Scripts%2FRhinoceros%5FToolkit%2FRhinoceros%5FToolkit%2DIssue91%2DClosedBRep&FolderCTID=0x0120008122C8891F89054B8ACED0196C70DFC4

@al-fisher
Copy link
Member Author

See comment on PR here: #171 (review)

image

@michaelhoehn
Copy link
Contributor

Potentially related issue #121

@michaelhoehn
Copy link
Contributor

Worth looking into this more closely in 7.1.

@michaelhoehn michaelhoehn self-assigned this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LMarkowski LMarkowski

@michaelhoehn michaelhoehn

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@al-fisher @LMarkowski @michaelhoehn