Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid check on ToRhino for extrusion #223

Open
IsakNaslundBh opened this issue May 9, 2022 · 0 comments
Open

invalid check on ToRhino for extrusion #223

IsakNaslundBh opened this issue May 9, 2022 · 0 comments
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@IsakNaslundBh
Copy link
Contributor

Description:

Method as a error in the check for if a extrusion can be returned (curve planar with a normal aligned with the direction vector of the extrusion). The check for parallel vectors should check if the angle is < than tolerance or if the angle -PI (180 degrees) is within tolerance. Currently instead checks against 2*PI (360degrees)

Steps to reproduce:

Make a BHoM extrusion object with a planar curve with a normal vector that is antiparallel with the direction vector.

Expected behaviour:

Test file(s):

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label May 9, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

1 participant