Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling to indicate cause of error and if overall push worked or not, especially with "Cannot distribute outlines error" for panel pushes #212

Open
enarhi opened this issue Jan 5, 2023 · 0 comments
Labels
type:bug Error or unexpected behaviour

Comments

@enarhi
Copy link
Member

enarhi commented Jan 5, 2023

Description:

Currently an opaque error is returned if pushing, and then trying to push again. This error is due to the inability to do a repeated push in this way, and should be handled with a reported error accordingly. We should also have clear error handling for floors, as they currently report an error when the DistributeOutlines method fails for the collection of floors on a single story. When this occurs, the fragment setting can also fail, throwing a similarly opaque error that implies the push failed when all other elements actually still pushed correctly.

Steps to reproduce:

Toggle push to true, false, and true again when pushing levels and other elements. Our standard structural test script includes floors that trigger the distribute outlines failure described above as well, which then returns the mentioned opaque error.

Expected behaviour:

Errors clearly indicating what went wrong, and what still worked, along with info needed to resolve the error.

Test file(s):

Structural base push test script.

@enarhi enarhi added the type:bug Error or unexpected behaviour label Jan 5, 2023
@enarhi enarhi changed the title Improve error handling to indicate cause of error and if overall push worked or not Improve error handling to indicate cause of error and if overall push worked or not, especially with "Cannot distribute outlines error" for panel pushes Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

1 participant