Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation Method Consistent Behavior for Nested Elements #282

Open
enarhi opened this issue Aug 25, 2022 · 0 comments
Open

Evaluation Method Consistent Behavior for Nested Elements #282

enarhi opened this issue Aug 25, 2022 · 0 comments
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@enarhi
Copy link
Member

enarhi commented Aug 25, 2022

Description:

Currently, LCA_Toolkit has inconsistent behavior for elements with nested elements. Per BHoM/BHoM_Engine#2895, all elements should return their volumes and aggregate materials including all nested elements. Accordingly, a Wall with Openings fed into the LCA Evaluate method should return results inclusive of the values of the nested Opening Elements.

Steps to reproduce:

Evaluate elements with nested elements, such as Physical Walls of Facade Panels with Openings.

Expected behaviour:

Result inclusive of all nested elements the element contains in accordance with general BHoM compliance, agreed on per BHoM/BHoM_Engine#2895.

@enarhi enarhi added the type:bug Error or unexpected behaviour label Aug 25, 2022
@enarhi enarhi changed the title Evaluation Method Consistent Behavior for Nested ELements Evaluation Method Consistent Behavior for Nested Elements Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

2 participants