Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of prototype TM65 method #242

Closed

Conversation

michaelhoehn
Copy link
Contributor

@michaelhoehn michaelhoehn commented Jul 26, 2021

Does not compile. Needs tweaking on line 143

NOTE: Depends on

BHoM/BHoM#1262

Issues addressed by this PR

Closes #204

Test files

Changelog

Additional comments

Does not compile. Needs tweaking on line 143
@michaelhoehn michaelhoehn self-assigned this Jul 26, 2021
@michaelhoehn michaelhoehn added the type:feature New capability or enhancement label Jul 26, 2021
Copy link
Member

@kayleighhoude kayleighhoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing individual parts

EPDComplexity scaleUpFactor = EPDComplexity.Undefined;

// Class 1 objects > scaleUpFactor == 1.1
List<string> class1 = new List<string>() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove individual parts below (pipes, cables, ducts, etc)

"UPS"
};

// Needs null handling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complexity to be explicit input, enum and method to have helper text on the input for this item giving examples of Class 1,2,3 complexities

[Input("weight", "Weight of the equipment in kg.")]
[Input("quantity", "The amount of determined QuantityType.")]
[Input("materialComposition", "The material composition of the object being evaluated. This is a breakdown of materials by ratio.")]
[Output("environmentalMetric", "Percentage reinforcement within concrete building element m^3.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add input for "AdditionalEPDData" to add source information for manufacturer etc

{
// TM65 calculation
// TotalWeight x ExplicitBulkByMass x 1.1 (ReplacementWeightIncrease) x Scale Up Factor x 1.3 (Buffer Factor) + RefrigerantTotalFromImageBelow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "Other" material option for anything under 100% in ratios for materials, that has specific value in TM65


// TODO Only use kg based EPDs and remove the Mass query -> give error message if QT is not kg

double totalQuantity = weight * /*BH.Engine.Matter.Query.Mass(materialComposition)*/ replacementWeightIncrease * scaleFactor * bufferFactor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calculation for material ratios to be multiplied by the object weight specified (mass addition)

@michaelhoehn
Copy link
Contributor Author

Closing this as the approach and code are now outdated and require a reassessment prior to merging. This has been documented as a requested feature and will be reviewed in a later milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluation Method Based on CIBSE TM65 Embodied Carbon for Building Services
2 participants