You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm including the functionality requested in issue #148 in an upcoming PR and would like to make sure we confirm the validity of the values across our datasets to make use of this valuable information.
Let's elevate this issue to an appropriate status once we have good enough cause to effect any changes (feature, bug, compliance, etc.). Not sure what to call it at this point as we already have the feature integrated into the oM as a default value. I'm just questioning whether these values are correct since we introduced the value after the datasets were generated.
Hope that's clear! Let's continue the chat below and update on which datasets have been checked.
The text was updated successfully, but these errors were encountered:
Hi @michaelhoehn , I completed the review of the ICE dataset and have recorded my changes in this excel document. I looked back at the original ICE dataset too just to double check things. With this review I've focused on QuantityTypes and QuantityTypeValues and picked up a few other small changes. I've turned the tabs in the excel green (no changes) or orange (changes needed) to help you locate the changes. Happy to do the same for other datasets as well. 201210_ICE dataset review_AJ.xlsx
I'm including the functionality requested in issue #148 in an upcoming PR and would like to make sure we confirm the validity of the values across our datasets to make use of this valuable information.
Let's elevate this issue to an appropriate status once we have good enough cause to effect any changes (feature, bug, compliance, etc.). Not sure what to call it at this point as we already have the feature integrated into the oM as a default value. I'm just questioning whether these values are correct since we introduced the value after the datasets were generated.
Hope that's clear! Let's continue the chat below and update on which datasets have been checked.
The text was updated successfully, but these errors were encountered: