Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuantityTypeValues for all datasets needs to be confirmed #171

Open
michaelhoehn opened this issue Dec 2, 2020 · 1 comment
Open

QuantityTypeValues for all datasets needs to be confirmed #171

michaelhoehn opened this issue Dec 2, 2020 · 1 comment
Assignees
Labels
type:question Ask for further details or start conversation

Comments

@michaelhoehn
Copy link
Contributor

I'm including the functionality requested in issue #148 in an upcoming PR and would like to make sure we confirm the validity of the values across our datasets to make use of this valuable information.

Let's elevate this issue to an appropriate status once we have good enough cause to effect any changes (feature, bug, compliance, etc.). Not sure what to call it at this point as we already have the feature integrated into the oM as a default value. I'm just questioning whether these values are correct since we introduced the value after the datasets were generated.

Hope that's clear! Let's continue the chat below and update on which datasets have been checked.

@michaelhoehn michaelhoehn added the type:question Ask for further details or start conversation label Dec 2, 2020
@ajensen19
Copy link
Contributor

Hi @michaelhoehn , I completed the review of the ICE dataset and have recorded my changes in this excel document. I looked back at the original ICE dataset too just to double check things. With this review I've focused on QuantityTypes and QuantityTypeValues and picked up a few other small changes. I've turned the tabs in the excel green (no changes) or orange (changes needed) to help you locate the changes. Happy to do the same for other datasets as well.
201210_ICE dataset review_AJ.xlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question Ask for further details or start conversation
Projects
None yet
Development

No branches or pull requests

3 participants