Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically explode returned IOutputObejcts #269

Closed
wants to merge 2 commits into from
Closed

Automatically explode returned IOutputObejcts #269

wants to merge 2 commits into from

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#894
BHoM/BHoM_Engine#1805

Issues addressed by this PR

Closes #268

  • Auto explode the properties from an returned obejct implementing the IOutputObject interface
  • Filter out IOutputObjects from CreateType and ConstructableItem lists

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added type:feature New capability or enhancement status:WIP PR in progress and still in draft, not ready for formal review labels May 26, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.2 β MVP milestone May 26, 2020
@IsakNaslundBh IsakNaslundBh requested review from rwemay and al-fisher May 26, 2020 16:20
@IsakNaslundBh IsakNaslundBh self-assigned this May 26, 2020
@adecler adecler self-requested a review June 2, 2020 02:46
@IsakNaslundBh IsakNaslundBh added the status:parked PR on hold, requiring further discussion or planning label Sep 22, 2020
@IsakNaslundBh
Copy link
Contributor Author

Closing this PR as development and discussions have moved on. Leaving issue open, with a parked label on it for further reference.

@adecler
Copy link
Member

adecler commented Jan 14, 2021

@IsakNaslundBh , was that intentional that you didn't delete the branch ?

@IsakNaslundBh IsakNaslundBh deleted the Reflection_oM-893-AddIOutputObejctInterfaceForCustomAutoExplodeReturnObjects branch January 14, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwemay rwemay Awaiting requested review from rwemay

@al-fisher al-fisher Awaiting requested review from al-fisher

@adecler adecler Awaiting requested review from adecler

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
status:parked PR on hold, requiring further discussion or planning status:WIP PR in progress and still in draft, not ready for formal review type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.

BHoM_UI: AutoExplode properties of IOutputObjects
2 participants
@IsakNaslundBh @adecler