Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return metadata for ALL location / variable combos that don't have data? #21

Open
dschristianson opened this issue Dec 17, 2020 · 0 comments
Labels

Comments

@dschristianson
Copy link
Contributor

Consider making a metadata entry for every location / variable combination specified?

Issue #19: We handled empty data returns from the datasource by making a metadata entry for that return with no start / end dates or number of records. We anticipate this to be useful for users to understand what locations - variables combos do not have data.

For USGS, empty data value arrays are returned for location - variable combos that exist in the USGS dataset but that do not have values for the date range specified. Unclear how other data sources might handle this.

If we expand the metadata return to include ALL location-variable combos regardless if the data source returns an empty array or not, it would probably be good to indicate which case it is (we generate an empty combo versus the data source returns an empty data array with what that means for each data source).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants