From cfca2d5447816e193542e78908c1d8e4fbed04e9 Mon Sep 17 00:00:00 2001 From: Kanishk Panwar Date: Tue, 19 May 2015 08:25:32 -0700 Subject: [PATCH 1/2] put fix for office in main branch. put fix for office in main branch. support NTLM handler for cases where webview is provided by developer --- ADALiOS/ADALiOS/ADAuthenticationBroker.m | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ADALiOS/ADALiOS/ADAuthenticationBroker.m b/ADALiOS/ADALiOS/ADAuthenticationBroker.m index 33b02d182..ef2831a60 100644 --- a/ADALiOS/ADALiOS/ADAuthenticationBroker.m +++ b/ADALiOS/ADALiOS/ADAuthenticationBroker.m @@ -226,7 +226,13 @@ - (void)start:(NSURL *)startURL // Save the completion block _completionBlock = [completionBlock copy]; ADAuthenticationError* error = nil; - + + _ntlmSession = [ADNTLMHandler startWebViewNTLMHandlerWithError:nil]; + if (_ntlmSession) + { + AD_LOG_INFO(@"Authorization UI", @"NTLM support enabled."); + } + if (webView) { AD_LOG_INFO(@"Authorization UI", @"Use the application provided WebView."); @@ -257,12 +263,6 @@ - (void)start:(NSURL *)startURL if (parent) { - _ntlmSession = [ADNTLMHandler startWebViewNTLMHandlerWithError:nil]; - if (_ntlmSession) - { - AD_LOG_INFO(@"Authorization UI", @"NTLM support enabled."); - } - parentController = parent; // Load our resource bundle, find the navigation controller for the authentication view, and then the authentication view UINavigationController *navigationController = [[self.class storyboard:&error] instantiateViewControllerWithIdentifier:@"LogonNavigator"]; From 1eac790db19361d80fd0a1a0fa9a623131738e45 Mon Sep 17 00:00:00 2001 From: Kanishk Panwar Date: Tue, 19 May 2015 08:30:05 -0700 Subject: [PATCH 2/2] prepare for release prepare for release --- ADALiOS.podspec | 2 +- ADALiOS/ADALiOS/ADALiOS.h | 2 +- ADALiOS/ADALiOSBundle/ADALiOSBundle-Info.plist | 4 ++-- changelog.txt | 4 ++++ 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ADALiOS.podspec b/ADALiOS.podspec index b8e0843e9..25f2a6a2f 100644 --- a/ADALiOS.podspec +++ b/ADALiOS.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "ADALiOS" - s.version = "1.2.3" + s.version = "1.2.4" s.summary = "The ADAL SDK for iOS gives you the ability to add Azure Identity authentication to your application" s.description = <<-DESC diff --git a/ADALiOS/ADALiOS/ADALiOS.h b/ADALiOS/ADALiOS/ADALiOS.h index 8886940a4..36a5ef124 100644 --- a/ADALiOS/ADALiOS/ADALiOS.h +++ b/ADALiOS/ADALiOS/ADALiOS.h @@ -20,7 +20,7 @@ //version in static define until we identify a better place: #define ADAL_VER_HIGH 1 #define ADAL_VER_LOW 2 -#define ADAL_VER_PATCH 3 +#define ADAL_VER_PATCH 4 #import "ADLogger.h" #import "ADErrorCodes.h" diff --git a/ADALiOS/ADALiOSBundle/ADALiOSBundle-Info.plist b/ADALiOS/ADALiOSBundle/ADALiOSBundle-Info.plist index b9d1cb18b..307965f33 100644 --- a/ADALiOS/ADALiOSBundle/ADALiOSBundle-Info.plist +++ b/ADALiOS/ADALiOSBundle/ADALiOSBundle-Info.plist @@ -17,11 +17,11 @@ CFBundlePackageType BNDL CFBundleShortVersionString - 1.2.3 + 1.2.4 CFBundleSignature ???? CFBundleVersion - 1.2.3 + 1.2.4 NSHumanReadableCopyright Copyright © 2013 MS Open Tech. All rights reserved. NSPrincipalClass diff --git a/changelog.txt b/changelog.txt index 258eca7f4..59c9f7c48 100644 --- a/changelog.txt +++ b/changelog.txt @@ -1,3 +1,7 @@ +Version 1.2.4 +------------- +* Support NTLM for developers who provide custom webview. + Version 1.2.3 ------------- * Fix a bug (#316) where non-ASCII input would result in a nil base64 value.