From 734043319d92afc04d55c2cd80623acc513a67bf Mon Sep 17 00:00:00 2001
From: Aviral Takkar <avtakkar@microsoft.com>
Date: Mon, 1 Apr 2024 16:10:01 -0700
Subject: [PATCH] docs: add some metrics examples

---
 README.md                                   | 29 +++++++++++++++++++++
 build/package/peerd-helm/templates/rbac.yml |  2 +-
 internal/metrics/prometheus.go              |  2 +-
 3 files changed, 31 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 0517921..3382d94 100644
--- a/README.md
+++ b/README.md
@@ -66,6 +66,35 @@ kubectl --context=$CLUSTER_CONTEXT -n peerd-ns logs -l app=peerd -f
 Peerd exposes metrics on the `/metrics/prometheus` endpoint. Mmetrics are prefixed with `peerd_`. `libp2p` metrics are
 prefixed with `libp2p_`.
 
+#### Examples on a 5 node AKS cluster, node sizes: `Standard_D2s_v3` and `Standard_D8ds_v5`
+
+1. How long does it take for a node to find a peer that has a key?
+
+    ```promql
+    sum(histogram_quantile(0.95, peerd_peer_discovery_duration_seconds_bucket)) by (self)
+    ```
+
+    | Node        | Time (s) |
+    | ----------- | -------- |
+    | peerd-xkjm  | 0.0156   |
+    | peerd-j6kf4 | 0.0619   |
+    | peerd-pj68b | 0.0451   |
+    | peerd-v8ndj | 0.0054   |
+    | peerd-8csx9 | 0.00834  |
+
+2. Peer download speed distribution?
+   
+    ```promql
+    sum(histogram_quantile(0.95, peerd_peer_response_speed_mib_per_second_bucket)) by (self)
+    ```
+
+    | Node        | Throughput (MiB/s) |
+    | ----------- | ------------------ |
+    | peerd-xkjm  | 173                |
+    | peerd-j6kf4 | 260                |
+    | peerd-pj68b | 118                |
+    | peerd-v8ndj | 333                |
+    | peerd-8csx9 | 324                |
 
 ## Features
 
diff --git a/build/package/peerd-helm/templates/rbac.yml b/build/package/peerd-helm/templates/rbac.yml
index 6c82f3f..71d5d94 100644
--- a/build/package/peerd-helm/templates/rbac.yml
+++ b/build/package/peerd-helm/templates/rbac.yml
@@ -45,7 +45,7 @@ metadata:
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-  name: peerd-manager-role
+  name: {{ include "peerd.name" . }}-manager-role
 subjects:
   - kind: ServiceAccount
     name: {{ include "peerd.serviceAccountName" . }}
diff --git a/internal/metrics/prometheus.go b/internal/metrics/prometheus.go
index 5d1e69e..0f33935 100644
--- a/internal/metrics/prometheus.go
+++ b/internal/metrics/prometheus.go
@@ -66,7 +66,7 @@ func NewPromMetrics(reg prometheus.Registerer) *promMetrics {
 	reg.MustRegister(peerResponseDurationHist)
 
 	upstreamResponseDurationHist := prometheus.NewHistogramVec(prometheus.HistogramOpts{
-		Name:    "peerd_upstream_response_speed_mib_per_seconds",
+		Name:    "peerd_upstream_response_speed_mib_per_second",
 		Help:    "Speed of upstream response in Mib per second.",
 		Buckets: prometheus.LinearBuckets(1, 15, 200),
 	}, []string{"self", "hostname", "op"})