Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamping the tests #57

Open
aagusuab opened this issue Jul 11, 2022 · 1 comment
Open

Revamping the tests #57

aagusuab opened this issue Jul 11, 2022 · 1 comment
Labels
quality control Improvement opportunities

Comments

@aagusuab
Copy link
Member

  • Remove unnecessary nestings on the test
  • Namespace cannot be removed using Corev1.Namespace.Delete(). Remove all of the instances of this.
  • Remove anonymous functions within the Contexts, Its, etc.
  • Remove 1 to 1 nesting
@aagusuab aagusuab added the quality control Improvement opportunities label Jul 11, 2022
@aagusuab aagusuab changed the title Revamping the tests (Quality) Revamping the tests Jul 11, 2022
@ryanzhang-oss
Copy link

I am not sure if it's already included, here are something I observed

  1. remove all nested "by" function
  2. since delete namespace doesn't work, the test cannot rely on it to clean up
  3. an IT actually does something, it's not an IT if it's just a verification
  4. make the style consistent at least within one test file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality control Improvement opportunities
Projects
None yet
Development

No branches or pull requests

2 participants