Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR Workflow] Automatic sign-off/approval for PRs which have the same content as earlier PRs that were already signed-off #7356

Open
rkmanda opened this issue Nov 29, 2023 · 2 comments
Open

[PR Workflow] Automatic sign-off/approval for PRs which have the same content as earlier PRs that were already signed-off #7356

rkmanda opened this issue Nov 29, 2023 · 2 comments
Assignees
@konrad-jamrozik
Labels
Central-EngSys This issue is owned by the Engineering System team. openapi-alps Items pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/ Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@rkmanda
Copy link
Member

rkmanda commented Nov 29, 2023 •
edited by konrad-jamrozik
Loading

Sometimes we encounter PRs that are raised against the "main" branch from a "release" branch which has merges based on PRs that were already signed off by ARM.

The ARM API reviewer in such cases does the following

  • Checks if the last PR submitted against the release branch was signed off by ARM
  • Checks if there are 0 diffs between the files in that signed off PR vs the file submitted with the current PR

If they are found to be the same, the ARMSignedOff label is automatically placed on such PRs. We would like for this process to be automated.

Related work:
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 29, 2023
@konrad-jamrozik konrad-jamrozik changed the title Automatic sign off for PRs which have the same content as earlier PRs that were already signed off [PR Workflow] Automatic sign off for PRs which have the same content as earlier PRs that were already signed off Nov 29, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Nov 29, 2023
@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 29, 2023
@konrad-jamrozik konrad-jamrozik added the openapi-alps Items pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/ label Nov 29, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🤖🧠 Nov 29, 2023
@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools Nov 29, 2023
@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Nov 29, 2023 •
edited
Loading

This work item is one of the many work items about streamlining and making more accurate the process of determining which kinds of reviews are required when. For related issues, see list here:

@konrad-jamrozik
Copy link
Contributor

Note: we will also have to update the https://aka.ms/azsdk/pr-diagram and automated PR comments appropriately.

@konrad-jamrozik konrad-jamrozik changed the title [PR Workflow] Automatic sign off for PRs which have the same content as earlier PRs that were already signed off [PR Workflow] Automatic sign-off/approval for PRs which have the same content as earlier PRs that were already signed off Nov 30, 2023
@konrad-jamrozik konrad-jamrozik changed the title [PR Workflow] Automatic sign-off/approval for PRs which have the same content as earlier PRs that were already signed off [PR Workflow] Automatic sign-off/approval for PRs which have the same content as earlier PRs that were already signed-off Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team. openapi-alps Items pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/ Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Azure SDK EngSys 🤖🧠
Status: 📋 Backlog
Spec PR Tools
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@konrad-jamrozik @rkmanda