Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking Change] BreakingChangeReviewRequired label should be added but bot doesn't do that #6331

Open
kazrael2119 opened this issue Jun 13, 2023 · 2 comments
Open

[Breaking Change] BreakingChangeReviewRequired label should be added but bot doesn't do that #6331

kazrael2119 opened this issue Jun 13, 2023 · 2 comments
Assignees
@konrad-jamrozik
Labels
Breaking Changes Improvements to Breaking Changes tooling Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@kazrael2119
Copy link
Contributor

in this pr:Azure/azure-rest-api-specs#24296
breaking change check is failed , and in ci Swagger Breaking Change is required to review, but bot doesn't add "BreakingChangeReviewRequired" label. Instead , if I add this label manually, after running/azp run or updating changes by author, this label will be removed by bot.
I think it is a bug
@kazrael2119 kazrael2119 added the Spec PR Tools Tooling that runs in azure-rest-api-specs repo. label Jun 13, 2023
@konrad-jamrozik konrad-jamrozik changed the title "BreakingChangeReviewRequired" label should be added but bot doesn't do that [Breaking Change] BreakingChangeReviewRequired label should be added but bot doesn't do that Jun 13, 2023
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Jun 13, 2023
@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Jun 13, 2023 •
edited
Loading

This is possibly because there was a runtime error

Adding to:

@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools Jun 13, 2023
@mikekistler mikekistler added the Breaking Changes Improvements to Breaking Changes tooling label Jul 7, 2023
@mikekistler
Copy link
Member

This may be a dup of #7770

@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🤖🧠 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Breaking Changes Improvements to Breaking Changes tooling Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Azure SDK EngSys 🤖🧠
Status: 📋 Backlog
Spec PR Tools
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@konrad-jamrozik @mikekistler @kazrael2119