Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fails due to a breaking change in browser test recordings #32851

Open
HarshaNalluru opened this issue Feb 3, 2025 · 1 comment
Open

CI fails due to a breaking change in browser test recordings #32851

HarshaNalluru opened this issue Feb 3, 2025 · 1 comment
Assignees
@HarshaNalluru
Labels
EngSys This issue is impacting the engineering system. test-utils-recorder Label for the issues related to the common recorder

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Feb 3, 2025 •
edited
Loading

Issue

#32839

https://dev.azure.com/azure-sdk/public/_build/results?buildId=4529244&view=logs&j=69104f8e-b88e-5d11-595c-90fd5e8e65ca&t=4ba20f2a-6568-5c82-27d3-3f34c36a0661&l=421

Image

"Origin" header being the difference [caused perhaps by the playwright upgrade??]

Current Fix

Re-recording the tests #32844

TO DO

Update recorder to ignore the header and its presence.
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 3, 2025
@HarshaNalluru HarshaNalluru self-assigned this Feb 3, 2025
@xirzec xirzec added EngSys This issue is impacting the engineering system. test-utils-recorder Label for the issues related to the common recorder and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 3, 2025
@jeremymeng
Copy link
Member

It may be related to whether web security is disabled or not?

jeremymeng added a commit to jeremymeng/azure-sdk-for-js that referenced this issue Feb 5, 2025
@jeremymeng
[test] update arm-playwrighttesting browser recording
722d629 
to remove "<Origin>"

Related issue: Azure#32851
@jeremymeng jeremymeng mentioned this issue Feb 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HarshaNalluru HarshaNalluru

Labels
EngSys This issue is impacting the engineering system. test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xirzec @jeremymeng @HarshaNalluru